Any idea when/if this will be merged? I just updated the Nuxt Firebase module which has firebase v8 as a requirement.

Codecov Report

Merging #940 (b8732f7) into master (d5f5ec2) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #940   +/-   ##
=======================================
  Coverage   94.89%   94.89%           
=======================================
  Files          14       14           
  Lines         372      372           
  Branches       64       64           
=======================================
  Hits          353      353           
  Misses          1        1           
  Partials       18       18           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5f5ec2...ac4a707. Read the comment docs.

Hello,
to simplify review of this pull request.

summary content:

• dependency firebase in package.json ^7.2.3 -> ^8.1.1
• import { XXX } from 'firebase' changed to import firebase from 'firebase/app'.
• versions (i'm not sure, if it's necessary):
  • @posva/vuefire-core version "2.3.3" changed to "2.3.4"
  • vuefire version "2.2.4" changed to "2.2.5"
  • vuexfire version "3.2.4" changed to "3.2.5"

that all.

minor:

• in firebase 8.0.0. timestampsInSnapshots has been remove from FirestoreSettings. So documentation could be clean up. see firebase release note

For this PR, i trusted the tests to validate that it has no regression.
But i wanted to test in my personal project. And the result is not good.

My error:
I use bindFirestoreRef(path, ref_to_collection). This collection contains objects that have a Firebase document reference on a field. The function isDocumentRef don't detect this child like a Firebase DocumentReference (no onSnapshot method on child object)

I tried a quick fix:

function isDocumentRef(o) {
    // return (o && o.onSnapshot)
    return (o && o.firestore)
}
// ...
function recursiveExtract(...){
   // ...
   if (isDocumentRef(ref)) {
       ref = ref.firestore.app.firestore().doc(ref.path)

This looks ok, but I don't see any changes in the Firebase release note that might explain this.

I'm not sure how to install it locally.

1. yarn build on the root folder of vuefire git clone
2. on my project:
   • add yarn add @posva/vuefire-core@file://${GIT_CLONE_PATH}/vuefire/packages/@posva/vuefire-core/
   • add yarn add vuexfire@file://${GIT_CLONE_PATH}/vuefire/packages/vuexfire

@postva: this installation sounds good to you or you see some side effects which may explain this error ?

@glemmatim: Could you test on your side ?

Created firebase/firebase-js-sdk#4134 to know more about it since we don' have access to firestore inside of that function to create the reference and this looks like a breaking change in firebase

Apparently it's being tracked at firebase/firebase-js-sdk#4125

My last test with firebase@8.1.2 is OK. The bug without onSnapshot method has been fixed.

I also deleted the changes in the versions.

How can I upgrade my vuefire package to the latest that uses firebase v8

How can I upgrade my vuefire package to the latest that uses firebase v8

Change the version of VueFire in package.json to 2.3.4
Edit: sorry => 2.2.5

2.3.4 is not available. Perhaps there are new versions 3.0.0-alpha.1. I will give that a try.

@mfissehaye - I see you now discovered 2.2.5! Sorry about the confusion.

For future reference, I recommend the following (instead of trusting me!) - it automatically bumps your package.json to the latest (non-alpha/beta) versions:

// Only once (to install globally)
npm i -g npm-check-updates

// Update package.json
ncu -u

// Install new versions from package.json
npm i

I do recommend some caution; it will update major versions (which might include breaking changes). I usually review the git diff before committing & discard anything that's giving me problems.

I am still getting error Uncaught TypeError: Cannot convert undefined or null to object with versions updated.

"vuefire": "^2.2.5",
"vuexfire": "^3.2.5"

Here is the vuexfire code

    const currentUser = this.$fire.auth.currentUser
    if (currentUser) {
      const uid = currentUser.uid
      const carts = this.$fire.firestore.collection(`users/${uid}/carts`)
      return await context.bindFirestoreRef('carts', carts, { wait: true })
    }

Note: I am subscribing to a sub collection.